Conversation
Evalir
left a comment
There was a problem hiding this comment.
For future reference—we will be merging this and other expect* changes into a feature branch
|
Could you please cut another release, @mattsse? Our tests are failing now: |
|
already running, sorry about the inconvenience |
|
TY @mattsse! Also, FWIW, I don't think the implementation in #4986 works as expected. Our tests already adhere to the rule of not counting calls made at the root test level, so it's strange that we started getting errors. FWIW, the depth in our case is greater than usual, as we're routing the calls via delegatecall, specifically via the Lmk if you'd like access to the private repo @mattsse @Evalir for investigation. We have a CI run that failed: https://github.com/sablier-labs/v2-periphery/actions/runs/5071179085/jobs/9107504005 |
|
Hey @PaulRBerg, gotcha, this is great feedback. We're gonna start merging these into a feature branch, so we can run extended QA on big repos that use foundry heavily and not break CIs—we'll integrate prb-math and prb-proxy into external integration tests for this as well. Would love access to the private repo—that way I can run QA and debug what might not be working as expected! |
|
Can confirm that the latest release ( |
|
Amazing, great to hear. Will probably be poking around really soon and testing with the new/upcoming changes! |
Reverts #4986
this was blocked for 1.0 and should not have been merged yet.