feat(forge): overload expectCall and mockCall with msg.value#1619
Merged
onbjerg merged 6 commits intofoundry-rs:masterfrom May 16, 2022
Merged
feat(forge): overload expectCall and mockCall with msg.value#1619onbjerg merged 6 commits intofoundry-rs:masterfrom
expectCall and mockCall with msg.value#1619onbjerg merged 6 commits intofoundry-rs:masterfrom
Conversation
Contributor
Author
|
Should I also do a PR to forge-std to add the new calls to |
Member
|
Yes! |
onbjerg
approved these changes
May 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1568
Closes #1604
expectCallwithmsg.valuemockCallwith `msg.valuemockCallpartial calldata matchingSolution
Implementation for the overloading of
expectCallwas straightforward with a newstructthat contains thecalldataandmsg.value.For the
mockCall,Ordtrait was implemented forMockCallDataContextto ensure that partial matching is consistent.The partial match now allows for the longest prefix in the calldata to be matched if there is no exact match.
There is also a new precedence order, and a more specific calldata precedes a
msg.valuematch with a shorter prefix calldata match.