Skip to content

feat(cheatcodes): disable usage of expectRevert with other expect* cheatcodes #5138

@Evalir

Description

@Evalir

When something reverts, the whole transaction unwinds and it's like nothing happened. However, expectCalls and expectEmits are still matched. We should not allow this to happen, but rather error if we have both a revert and another expect cheatcode being used together at the same time, for the next call.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions