Skip to content
This repository was archived by the owner on Apr 20, 2026. It is now read-only.

Flatten fix#68

Merged
mattsse merged 4 commits into
foundry-rs:mainfrom
klkvr:klkvr/flatten-fix
Feb 2, 2024
Merged

Flatten fix#68
mattsse merged 4 commits into
foundry-rs:mainfrom
klkvr:klkvr/flatten-fix

Conversation

@klkvr

@klkvr klkvr commented Feb 1, 2024

Copy link
Copy Markdown
Member

Ref foundry-rs/foundry#6936 (comment)

Not sure why exactly this unwrap is failing, adding None variant handling and some logs to debug it.

@klkvr klkvr requested review from DaniPopes, Evalir and mattsse and removed request for DaniPopes and Evalir February 1, 2024 16:19

@mattsse mattsse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pedantic nits

Comment thread src/flatten.rs Outdated
Comment on lines +464 to +465
match new_name {
Some(new_name) => {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use if let Some else

Comment thread src/flatten.rs Outdated
klkvr and others added 2 commits February 2, 2024 14:25
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
@mattsse mattsse merged commit 7b23450 into foundry-rs:main Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants