Improve JSON path documentation for writeJson and writeToml cheatcodes#1652
Merged
onbjerg merged 1 commit intofoundry-rs:masterfrom Sep 10, 2025
Merged
Improve JSON path documentation for writeJson and writeToml cheatcodes#1652onbjerg merged 1 commit intofoundry-rs:masterfrom
onbjerg merged 1 commit intofoundry-rs:masterfrom
Conversation
Member
|
Thanks! Changes make sense, pending review of @onbjerg |
onbjerg
approved these changes
Sep 10, 2025
Contributor
Author
|
@all-contributors please add @Signor1 |
Contributor
|
I couldn't determine any contributions to add, did you specify any contributions? |
Contributor
Author
|
@all-contributors please add @Signor1 for Maintenance |
Contributor
|
I've put up a pull request to add @Signor1! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1638
Clarifies JSON path syntax in the documentation for
vm.writeJsonandvm.writeTomlcheatcodes.Changes:
"key.foo"get silently converted to"$key.foo"and fail.or$(e.g.,".key.foo"or"$.key.foo")This addresses user confusion about why certain JSON paths don't work as expected.