fix: revise Meteor "fourseven:scss" compatibility for Meteor>1.4.1 support#125
Merged
ncoden merged 1 commit intofoundation:developfrom Jun 23, 2018
Merged
Conversation
…pport Foundation support all `fourseven:scss` versions from `v3.4`. Changes: * revise `fourseven:scss` compatibility to `3.4.1 || 4.0.0` to support older and newer Meteor versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Revise
fourseven:scsscompatibility to3.4.1 || 4.0.0to support older and newer Meteor versions.Motivation and Context
Foundation supports a large range of versions for
fourseven:scss(fromv3.4) and Meteor (fromv1.2.1). Meteor packages version resolution will use all newer minor and patch versions but not major versions.As
fourseven:scssversions require a particular Meteor versions, the latest releases are considered as incompatible with Motion UI. This pull request ensures that the Motion UI actual compatibility with Meteor and its packages matches the compatibility allowed by Meteor package management.Related to foundation/foundation-sites#11349