fix(abide): add aria-describedby to the input only if error is visible#12398
Merged
joeworkman merged 1 commit intofoundation:developfrom Jul 11, 2022
Merged
fix(abide): add aria-describedby to the input only if error is visible#12398joeworkman merged 1 commit intofoundation:developfrom
joeworkman merged 1 commit intofoundation:developfrom
Conversation
38cbfaf to
99c065d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
aria-describedbyattribute is added to the input field even when the form error is hidden from the view. This poses a problem for screen reader users who will hear e.g. that "there is an error in this field" even when there is no error yet.aria-describedbyto hidden form error messages #12393Types of changes
Checklist
developordevelop-v...).