docs: progress bar documentation fixes and notes for accessibility #12043#12085
Merged
joeworkman merged 2 commits intofoundation:developfrom Aug 24, 2021
Merged
docs: progress bar documentation fixes and notes for accessibility #12043#12085joeworkman merged 2 commits intofoundation:developfrom
joeworkman merged 2 commits intofoundation:developfrom
Conversation
The tabindex attribute makes the progress bars focusable and there is no real reason for them to be focusable. This change improves accessibility.
|
Kudos, SonarCloud Quality Gate passed!
|
3 tasks
joeworkman
approved these changes
Aug 24, 2021
joeworkman
approved these changes
Aug 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
tabindexattribute should not be defined for progress bar elements as this makes the progress bars focusable. There is no reason for them to be focusable by default.In addition, the behavior of the progress bar in screen readers deserves a section in the progress bar documentation as this is not obvious for developers.
Types of changes
Checklist
developordevelop-v...).