Skip to content

fix: Align specification error codes with implementation#38

Merged
jcleigh merged 2 commits into014-cross-repo-commitfrom
copilot/sub-pr-37
Jan 16, 2026
Merged

fix: Align specification error codes with implementation#38
jcleigh merged 2 commits into014-cross-repo-commitfrom
copilot/sub-pr-37

Conversation

Copy link
Contributor

Copilot AI commented Jan 16, 2026

The specification documents for fa commit and fa push referenced incorrect error codes that didn't match the actual error code definitions in internal/errors/codes.go, causing documentation-implementation mismatch.

Changes:

  • commit-cli.md: Corrected 6 error codes

    • E401→E501 (empty commit message)
    • E201→E005 (no repos configured)
    • E202→E507 (repo not found)
    • E402→E502 (detached HEAD)
    • Added E503 (nothing to commit)
  • push-cli.md: Corrected 8 error codes

    • E201→E005 (no repos)
    • E202→E507 (repo not found)
    • E301→E506 (remote rejected)
    • E302→E508 (no upstream)
    • E303→E402 (auth failed)
    • E304→E509 (force push denied)
    • Added E504 (nothing to push)
  • spec.md: Updated detached HEAD reference from E402→E502

All error codes now align with their definitions in internal/errors/codes.go:

// Commit/Push errors (E5xx)
ErrCodeEmptyCommitMessage = "E501"
ErrCodeDetachedHead       = "E502"
ErrCodeNothingToCommit    = "E503"
ErrCodeNothingToPush      = "E504"
ErrCodePushFailed         = "E506"
ErrCodeRepoNotFound       = "E507"
ErrCodeNoUpstream         = "E508"
ErrCodeForcePushDenied    = "E509"

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…tation

Co-authored-by: jcleigh <12815554+jcleigh@users.noreply.github.com>
Copilot AI changed the title [WIP] Add cross-repo commit and push functionality fix: Align specification error codes with implementation Jan 16, 2026
Copilot AI requested a review from jcleigh January 16, 2026 14:54
@jcleigh jcleigh marked this pull request as ready for review January 16, 2026 15:12
@jcleigh jcleigh merged commit dcded9d into 014-cross-repo-commit Jan 16, 2026
@jcleigh jcleigh deleted the copilot/sub-pr-37 branch January 16, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants