Closed
Conversation
Owner
|
Hell yeah! I'm happy to hear you're learning some Haskell. I'll do a proper review later on. For now, no there's nothing you need to sign IP-wise. Do copy the license header to the top of the module, though. |
Contributor
Author
|
Also, not sure if the CI failing with |
Owner
|
I wouldn't worry too much about the nightly. |
Owner
|
#459 might supersede this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Fosskers,
I created this pull request as I saw the plans for version 1.4 include a .SRCINFO parser in Haskell.
I took this as an opportunity to learn Haskell a bit, so thanks to this code I've officially written some Haskell, and learnt quite a lot in the process about MegaParsec, Tasty, Stack…
I'm sure this code may not look great, but I'm here to help and learn.
This parses a regular format of SRCINFO, but not the one where multiples values (like for arch) are given as a n-uplet.
I'm not sure how to continue on that direction as of yet, and I'd like some review on this code to try to steer it in the right direction.
Also, is there a close to sign/agree upon to give up intellectual property on this?
Do I need to copy a sub-set of the licence at the top of the files?