Skip to content

extensible-effects conversion#379

Merged
fosskers merged 10 commits intofosskers:aura-1.4from
theotherjimmy:ext-eff
Dec 23, 2015
Merged

extensible-effects conversion#379
fosskers merged 10 commits intofosskers:aura-1.4from
theotherjimmy:ext-eff

Conversation

@theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Dec 7, 2015

This was much harder to understand, and much easier to implement than I thought.

@theotherjimmy
Copy link
Contributor Author

theotherjimmy commented Dec 11, 2015

added the commit so that @fosskers and @bb010g can take a look.
But good god the compile errors right now.

@theotherjimmy
(unstable) take a look!
72c651f 
90% done with String ==> Text
90% done with MTL ==> Ext-Eff
mostly done with Shelly
theotherjimmy
theotherjimmy reviewed Dec 21, 2015
View reviewed changes
src/Aura/Shell.hs Outdated
Copy link
Contributor Author

@theotherjimmy theotherjimmy Dec 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually did that.

@fosskers
Copy link
Owner

fosskers commented Dec 21, 2015

It looks like this encompasses the Text conversion as well. I'll do some tweaks afterward to make the Shelly use a bit more seamless, and that should be much easier now.

@theotherjimmy
Copy link
Contributor Author

theotherjimmy commented Dec 21, 2015

Yep. I wanted to get it compiling to check that ext-eff conversion was working. I can confirm now that it is, but it took 1100 lines to check ~30.

so the three major changes in this PR:
String ==> Text
finished Shelly (no more Shell)
MTL ==> Extensible Effects.

theotherjimmy
theotherjimmy reviewed Dec 21, 2015
View reviewed changes
src/Aura/Build.hs
Copy link
Contributor Author

@theotherjimmy theotherjimmy Dec 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not use the empty list here, instead actually pass arguments to makepkg. it's there for type checking purposes right now.

@fosskers
Copy link
Owner

fosskers commented Dec 22, 2015

This is wonderful. Do you consider this good to go?

@theotherjimmy
Copy link
Contributor Author

theotherjimmy commented Dec 23, 2015

I do now. :D

@fosskers
Copy link
Owner

fosskers commented Dec 23, 2015

Do extensible-effects and type-aligned not have to be added to extra-deps in the stack.yaml? Travis seems to be building it fine regardless, though.

@theotherjimmy
Copy link
Contributor Author

theotherjimmy commented Dec 23, 2015

I don't know. I only use cabal.
On Dec 23, 2015 1:16 AM, "Colin Woodbury" notifications@github.com wrote:

Do extensible-effects and type-aligned not have to be added to extra-deps
in the stack.yaml? Travis seems to be building it fine regardless, though.

—
Reply to this email directly or view it on GitHub
#379 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theotherjimmy @fosskers