Merged
Conversation
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
7f04a9b to
81e4e3a
Compare
spatten
requested changes
Feb 7, 2025
Contributor
spatten
left a comment
There was a problem hiding this comment.
I'm a little confused about the discrepancy between the PR title and the change in the code.
Also, the tests are failing. Something about Yarn needing node 22. I think this is because the lockfile was generated with node 22 and the tests are running node 20.
Finally, we should probably update the version of node in this file: https://github.com/fossas/fossa-action/blob/main/.tool-versions
spatten
approved these changes
Feb 7, 2025
Contributor
spatten
left a comment
There was a problem hiding this comment.
Looks good!
I think we should update the node version in .tool-versions, but that's not blocking. I don't know where we actually use that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Updates node version of the action to v20x
Original PR by @mikeee at #45, recreated so we can run CI.
Checklist
yarn buildand committed resulting changes..github/workflows/test.ymlor explained why it doesn't make sense to do so.