Skip to content

Add config as an option (See issue #55)#56

Closed
pieterocp wants to merge 1 commit intofossas:mainfrom
pieterocp:add-config-path
Closed

Add config as an option (See issue #55)#56
pieterocp wants to merge 1 commit intofossas:mainfrom
pieterocp:add-config-path

Conversation

@pieterocp
Copy link
Contributor

Overview

See issue #55. I think this should allow for a config file to be slapped in somewhere else. But might be wrong on this.

Checklist

[X] If I changed code, I ran yarn build and committed resulting changes.
[ ] I added an example exercising this PRs functionality to .github/workflows/test.yml or explained why it doesn't make sense to do so.

  • I don't know what settings are part of this project, but if someone with this wants to slap it in a config/ then we could add it sure.

@pieterocp pieterocp requested a review from a team as a code owner January 22, 2025 20:01
@pieterocp pieterocp requested review from nficca and removed request for a team January 22, 2025 20:01
Copy link
Contributor

@nficca nficca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@nficca
Copy link
Contributor

nficca commented Jan 22, 2025

Hey @pieterocp — our workflows don't work from forks, so I've recreated your PR here: #59. Will close this one and merge that one. I've given you credit on the commit.

@nficca nficca closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants