Screaming snake case the example environment variables#54
Closed
pieterocp wants to merge 1 commit intofossas:mainfrom
Closed
Screaming snake case the example environment variables#54pieterocp wants to merge 1 commit intofossas:mainfrom
pieterocp wants to merge 1 commit intofossas:mainfrom
Conversation
…ion environment variables do)
Contributor
|
Thanks for this, @pieterocp. Because of how our workflows are set up, the simplest way to get this merged is for me recreate a PR with my account in order for the required checks to run. I will make sure that you are credited as the commit author, however. |
Contributor
Author
|
Splendid, thank you.
As long as it's done, happy days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
See Issue #30 for context.
Screaming snake cases the examples in the readme (as other github action environment variables do).
Checklist
[ ] If I changed code, I ran
yarn buildand committed resulting changes.[X]
I added an example exercising this PRs functionality toor explained why it doesn't make sense to do so..github/workflows/test.yml