Merged
Conversation
spatten
approved these changes
Aug 13, 2024
Contributor
spatten
left a comment
There was a problem hiding this comment.
Two minor comments, but other than that it looks great.
I agree that adding tests for this feature would be a larger lift and it's fine to leave it for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
--policyand--teamflags. I haven't updated the tests to include this because they require a new project in every case. We could set it up in a custom org and create a new project every time but I don't know if that's the right decision.I did set this up in a dummy repo and confirmed that it's working.