-
Notifications
You must be signed in to change notification settings - Fork 781
Add cookie assertions framework #868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you fix the merge conflict? |
Add a convenient workflow for running assertions on cookie headers
returned by the server. This code is largely copied from Gregory
Langais' package `expect-cookie` (MIT License).
Example usage:
```js
const request = require('supertest');
const cookies = request.cookies;
request(app)
.get('/users')
.expect('Content-Type', /json/)
.expect('Content-Length', '15')
.expect(200)
// assert 'alpha' cookie is set with domain, path, and httpOnly options
.expect(cookies.set({ name: 'alpha', options: ['domain', 'path', 'httponly'] }))
// assert 'bravo' cookie is NOT set
.expect(cookies.not('set', { name: 'bravo' }))
.end(function(err, res) {
if (err) {
throw err;
}
});
```
Supports:
- `.set` - Assert that cookie and options are set.
- `.reset` - Assert that cookie is set and was already set (in request
headers).
- `.new` - Assert that cookie is set and was NOT
already set (NOT in request headers).
- `.renew` - Assert that cookie is set with a strictly greater `expires`
or `max-age` than the given value.
- `.contain` - Assert that cookie is set with value and contains
options.
- `.not` - Call any cookies assertion method with "assert true" modifier
set to `false`.
feat(cookies): add cookie assertions
Add a convenient workflow for running assertions on cookie headers
returned by the server. This code is largely copied from Gregory
Langais' package `expect-cookies` (MIT License).
Example usage:
```js
const request = require('supertest');
const cookies = request.cookies;
request(app)
.get('/users')
.expect('Content-Type', /json/)
.expect('Content-Length', '15')
.expect(200)
// assert 'alpha' cookie is set with domain, path, and httpOnly options
.expect(cookies.set({ name: 'alpha', options: ['domain', 'path', 'httponly'] }))
// assert 'bravo' cookie is NOT set
.expect(cookies.not('set', { name: 'bravo' }))
.end(function(err, res) {
if (err) {
throw err;
}
});
```
Supports:
- `.set` - Assert that cookie and options are set.
- `.reset` - Assert that cookie is set and was already set (in request
headers).
- `.new` - Assert that cookie is set and was NOT
already set (NOT in request headers).
- `.renew` - Assert that cookie is set with a strictly greater `expires`
or `max-age` than the given value.
- `.contain` - Assert that cookie is set with value and contains
options.
- `.not` - Call any cookies assertion method with "assert true" modifier
set to `false`.
366c7ef to
4f89680
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Fixed. Sorry, not sure how that happened. |
|
Everything look ok now? |
A1exKH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
Cheers! |
|
v7.2.0 published to npm https://github.com/forwardemail/supertest/releases/tag/v7.2.0 please consider supporting our maintenance efforts by becoming a @forwardemail user! **sign up at https://forwardemail.net and use coupon code |
Add a convenient workflow for running assertions on cookie headers returned by the server. This code is largely copied from Gregory Langlais' package
expect-cookies(MIT License).Implements #855.
Example usage:
Supports:
.set- Assert that cookie and options are set..reset- Assert that cookie is set and was already set (in request headers)..new- Assert that cookie is set and was NOT already set (NOT in request headers)..renew- Assert that cookie is set with a strictly greaterexpiresormax-agethan the given value..contain- Assert that cookie is set with value and contains options..not- Call any cookies assertion method with "assert true" modifier set tofalse.Checklist