fix(brotli) remove re2 dependency #1813
Merged
titanism merged 1 commit intoforwardemail:masterfrom Aug 13, 2024
Merged
Conversation
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/re2@1.21.3 |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
This was referenced Aug 6, 2024
Contributor
Author
|
Hi @titanism - can we merge it? It will help to keep support for Node 14 as well |
Collaborator
|
It looks like this causes problems on some architectures, so we may need to look at an alternative. At a glance, it seems like the regular expressions here are actually safe: > require('safe-regex2')(/^\s*(?:deflate|gzip)\s*$/)
true
> require('safe-regex2')(/^\s*(?:br)\s*$/)
trueSo we may not need RE2 after all. Though this might need tested. |
Closed
3 tasks
Contributor
Author
|
@titanism - I removed re2. we have unit tests around that area |
Collaborator
|
superagent v10.0.1 is released (we removed |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a fixed version of re2 to maintain support for Node14 (now need 14.21.3)
Checklist