Skip to content

chore: classify agent#1777

Merged
titanism merged 1 commit intoforwardemail:masterfrom
jimmywarting:classify
Aug 19, 2023
Merged

chore: classify agent#1777
titanism merged 1 commit intoforwardemail:masterfrom
jimmywarting:classify

Conversation

@jimmywarting
Copy link
Copy Markdown
Contributor

@jimmywarting jimmywarting commented Aug 18, 2023 •
edited
Loading

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

hoping to have some more modernized codebase with classes and better IDE/autosuggestions.
some wishful thinking is also to be able to use private class method/fields later on.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 18, 2023 •
edited
Loading

Codecov Report

Patch coverage: 87.50% and project coverage change: -0.01% ⚠️

Comparison is base (cfb7b5e) 94.40% compared to head (fca95a3) 94.39%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1777      +/-   ##
==========================================
- Coverage   94.40%   94.39%   -0.01%     
==========================================
  Files          14       14              
  Lines        1143     1141       -2     
==========================================
- Hits         1079     1077       -2     
  Misses         64       64
Files Changed Coverage Δ
src/node/agent.js 88.88% <84.00%> (-0.70%) ⬇️
src/agent-base.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titanism
Copy link
Copy Markdown
Collaborator

titanism commented Aug 18, 2023

awesome work - let us know when ready for review. happy to have you as a collab/maintainer too on all of this

@jimmywarting jimmywarting changed the title classify agent chore: classify agent Aug 18, 2023
@jimmywarting
Copy link
Copy Markdown
Contributor Author

jimmywarting commented Aug 18, 2023

Thanks. I'm ready for a review.
I just did a simple PR to see if this is active/maintained and what kind of things you are acceptable of.
you can maybe expect more PR to come later on.

@titanism titanism merged commit 83e92cb into forwardemail:master Aug 19, 2023
@TheGamerzs TheGamerzs mentioned this pull request Jul 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jimmywarting @codecov-commenter @titanism