fix: handle BigInts that has a .toJSON property#1776
Merged
Conversation
Collaborator
|
Fixed and released in v8.1.2 - thank you @bjornua |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Problem
The recent changes introduced in #1773 restricts the usage of
BigIntwith the.send()method, even if theBigIntobject has a.toJSONmethod. In scenarios where developers want to serializeBigIntproperties to JSON, this becomes a limitation.Change
This pull request modifies the existing checks on
BigIntvalues passed to the.send()method. With this change, if aBigIntproperty has a.toJSONmethod, it will not throw the "Cannot serialize BigInt value to json" error.