Fix incorrect response object being emitted on redirect#1761
Merged
titanism merged 1 commit intoJan 25, 2023
Conversation
3 tasks
dbec926 to
8935ad9
Compare
8935ad9 to
e2538f3
Compare
wilsonjackson
commented
Jan 24, 2023
| _initHeaders(this); | ||
|
|
||
| // redirect | ||
| this.res = res; |
Contributor
Author
There was a problem hiding this comment.
@titanism This is the main change I'm not super certain about. Without doing this, a couple of the tests around .pipe() fail because there's no this.res on the response. I don't know if this assignment has the potential to screw anything else up.
6 tasks
Collaborator
|
v8.0.9 released to npm and GitHub releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the argument emitted with the redirect event to a Supertest
Responseobject instead of an unwrappedIncomingMessage.Closes #1760
Checklist