Skip to content

Send cookies to allowed domains#1757

Merged
titanism merged 1 commit into
forwardemail:masterfrom
ShiraNagen:cookies-domains
Jan 18, 2023
Merged

Send cookies to allowed domains#1757
titanism merged 1 commit into
forwardemail:masterfrom
ShiraNagen:cookies-domains

Conversation

@ShiraNagen

@ShiraNagen ShiraNagen commented Dec 15, 2022

Copy link
Copy Markdown
Contributor

Currently, superagent.agent() sends cookies to all requests without checking if the domains match the cookies and are allowed to use them.
This pull request solves this issue #1758.

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@titanism titanism merged commit 93835cb into forwardemail:master Jan 18, 2023
@titanism

Copy link
Copy Markdown
Collaborator

@titanism

Copy link
Copy Markdown
Collaborator

thank you for your contributions @ShiraNagen 👏 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants