Skip to content

Clean golangci-lint configuration#37

Merged
ldemailly merged 1 commit intofortio:mainfrom
ldez:feat/clean-golangci-lint-config
May 21, 2024
Merged

Clean golangci-lint configuration#37
ldemailly merged 1 commit intofortio:mainfrom
ldez:feat/clean-golangci-lint-config

Conversation

@ldez
Copy link
Copy Markdown
Contributor

@ldez ldez commented May 21, 2024

tips:

golangci-lint config verify --config golangci.yml

@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented May 21, 2024

Thanks a lot for cleaning up our config! greatly appreciated! of note, just filled #38

But I tested on fortio/fortio's and it worked

WARN [config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`. 
WARN The linter 'execinquery' is deprecated (since v1.58.0) due to: The repository of the linter has been archived by the owner.  
WARN [linters_context] copyloopvar: this linter is disabled because the Go version (1.19) of your project is lower than Go 1.22 
WARN [linters_context] intrange: this linter is disabled because the Go version (1.19) of your project is lower than Go 1.22

I suppose I should maybe also eventually remove execinquery but for now despite archive I think it's fine

Thanks again

@ldemailly ldemailly merged commit 38f8a15 into fortio:main May 21, 2024
@ldez ldez deleted the feat/clean-golangci-lint-config branch May 21, 2024 20:57
@ldemailly ldemailly mentioned this pull request May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ldez @ldemailly