Conversation
…lso introduce a colorstate to skip out noop color changes (to be moved to ansipixels later)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces color state optimization to reduce redundant ANSI color codes when rendering pixels. The changes add a ColorState struct to track the last set foreground and background colors, avoiding unnecessary color changes when the same colors are already active.
- Introduces
ColorStateto track current foreground/background colors - Replaces direct color setting calls with optimized color state methods
- Reduces redundant ANSI escape sequences by only setting colors when they change
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 5 5
Lines 579 590 +11
=====================================
- Misses 579 590 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One key characteristic of what we aim is smallest amount of bytes sent for a given rendering (note we should also optimize the cursor moves like we do in image showing and disc)
before
after