Skip to content

Offer go1.21 based version#72

Merged
ldemailly merged 1 commit intomainfrom
go1_21_base
Apr 6, 2025
Merged

Offer go1.21 based version#72
ldemailly merged 1 commit intomainfrom
go1_21_base

Conversation

@ldemailly
Copy link
Copy Markdown
Member

Fixes #66

of note the only point not done is

Rewrite RemoveCommon to use maps.DeleteFunc

because RemoveCommon removes from both and optimizes for the shortest set

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • go.mod: Language not supported
Comments suppressed due to low confidence (1)

sets.go:156

  • Ensure that the clear(s) function is defined and accessible within the package since replacing the explicit loop with clear(s) may lead to a compile error if clear is undefined.
clear(s)

@ldemailly ldemailly merged commit 91992e6 into main Apr 6, 2025
6 checks passed
@ldemailly ldemailly deleted the go1_21_base branch April 6, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade dependency on Go to 1.21

2 participants