Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 174 182 +8
=========================================
+ Hits 174 182 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds FlagVar and FlagSet variants of the duration flag functions to complete the API parity with Go's standard flag package. The changes prepare the package for a 1.0.0 release by providing all the flag registration variants that users would expect.
- Adds
FlagVarandFlagSetVarfunctions for binding duration flags to existing variables - Adds
FlagSetfunction for registering duration flags on specific flag sets - Refactors existing
Flagfunction to use the newFlagSetimplementation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| duration.go | Implements new flag variants and refactors existing Flag function to use FlagSet |
| duration_test.go | Adds test coverage for the new FlagVar functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
And better doc/examples
Should then be good for 1.0.0