Use new duration package with better parsing and to string#74
Merged
Use new duration package with better parsing and to string#74
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the dflag package to integrate a new duration package that provides enhanced duration parsing and string formatting capabilities. The changes add support for more human-readable duration formats like "3w2d4h" while maintaining backward compatibility.
Key changes:
- Add fortio.org/duration v1.0.0 dependency for enhanced duration parsing
- Extend DynValueTypes to support both time.Duration and duration.Duration types
- Update parsing logic to use the new duration package for better format support
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| go.mod | Adds fortio.org/duration v1.0.0 dependency |
| dyngeneric.go | Updates type constraints, parsing logic, and string formatting to support new duration package |
| dynduration.go | Updates copyright notice |
| dynduration_test.go | Adds tests for new duration format support and updates existing tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #73