Switch minimum go version to go1.21 - through sets update; drop x/exp; bump fsnotify to 1.8.0#70
Merged
Switch minimum go version to go1.21 - through sets update; drop x/exp; bump fsnotify to 1.8.0#70
Conversation
…p windows confimap test
There was a problem hiding this comment.
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (2)
- Makefile: Language not supported
- go.mod: Language not supported
Comments suppressed due to low confidence (3)
dyngeneric.go:320
- [nitpick] Ensure that the switch from constraints.Ordered to cmp.Ordered preserves the intended ordering semantics in all use cases now that Go 1.21 is required.
func ValidateRange[T cmp.Ordered](fromInclusive T, toInclusive T) func(T) error {
configmap/loglevel_change_test.go:59
- [nitpick] Consider removing the obsolete commented-out sleep statement to improve test clarity and maintainability.
// time.Sleep(5 * time.Second)
configmap/loglevel_change_test.go:93
- [nitpick] Increasing the sleep duration might slow down the tests; if possible, consider using an event-driven approach to wait for the desired state instead of a fixed delay.
time.Sleep(5 * time.Second)
…nd bump fsnotify too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.