Skip to content

custom event before/after offsets are ignored #941

@forrestguice

Description

@forrestguice

Describe the bug
The before/after offsets for some custom events are ignored. The "shadow length", "shadow ratio", "day percent", "moon illumination", and "moon elevation" events all ignore the offset. The "sun elevation" events apply the offset correctly.

To Reproduce

  1. Create a shadow length event without an offset.
  2. Create an identical event at 10 minute before.
  3. Observe that both events display the same time instead of differing by 10 minutes.

Expected behavior
The before/after offset should be applied to the event time.

Version Info:

  • App Version: v0.17.0
  • Android Version: 10

Additional context
Note: This bug is about offsets that are part of the event definition, and not "alarm offsets" (e.g. #940) which are slightly different.

The "shadow ratio", "day percent", "moon illumination", and "moon elevation" events were added in v0.17.0, but previous versions have this bug for the "shadow length" events.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions