Skip to content

Conversation

@vroskus
Copy link

@vroskus vroskus commented Mar 13, 2021

lodash-es dependency not listed in package.json

lodash-es dependency not listed in package.json
@rkuykendall
Copy link
Member

Okay, this is weird.

I can't just merge this PR and release, because this is a bug with the builder, so it would just re-build the source and introduce the bug.

I actually have no idea how this lodash-es is getting introduced, it's NOWHERE in the codebase unless I'm missing it. We use 'lodash' in the referenced files...

If you understand this at all @vroskus I'd appreciate your input, otherwise I hope someone else sees this PR and comments. Maybe @felixmosh who led the incredible tsdx move has some insight.

@felixmosh
Copy link
Contributor

It is one of TS during optimizations, it rewrites lodash imports with lodash-es, https://github.com/formium/tsdx#using-lodash

It says in docs to install both of the libs.

the question Ishay @vroskus encountered this errors?

@felixmosh
Copy link
Contributor

@vroskus thank for the PR, but it is not the correct one, we should add lodash-es to our deps

@felixmosh
Copy link
Contributor

felixmosh commented Mar 15, 2021

Fixed in v2.2.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants