Skip to content
This repository was archived by the owner on Jul 14, 2023. It is now read-only.

removing ajax creation for non gold accounts#173

Merged
colevscode merged 3 commits intoformspree:masterfrom
colevscode:gold-only-ajax
Feb 10, 2018
Merged

removing ajax creation for non gold accounts#173
colevscode merged 3 commits intoformspree:masterfrom
colevscode:gold-only-ajax

Conversation

@colevscode
Copy link
Copy Markdown
Member

@colevscode colevscode commented Feb 5, 2018

Changes proposed in this pull request:

  • Currently we're seeing a lot of spam come from ajax forms, since we must allow ajax to bypass the CAPTCHA. Unfortunately the most strait forward solution is to remove this capability.
  • This PR makes submitting AJAX forms a gold feature.
  • Existing forms will continue to work, even AJAX forms that have been created by non gold users.

Have you made sure to add:

  • Tests
  • Documentation

@fiatjaf
Copy link
Copy Markdown
Contributor

fiatjaf commented Feb 5, 2018

Looks good to me.

Copy link
Copy Markdown
Member

@rohitdatta rohitdatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I'm ready to merge it.

@colevscode colevscode merged commit d91088e into formspree:master Feb 10, 2018
@andri
Copy link
Copy Markdown

andri commented Mar 1, 2018

I'm pretty sure this did not work for all existing forms. I had three sites using your service and found out days later that my contact forms didn't work anymore.

It would have been nice to receive heads up before such crucial changes are made.

@rohitdatta
Copy link
Copy Markdown
Member

@andri that definitely wasn't the intended behavior. We tested this prior to deployment to ensure that it would only affect new forms and decided not to send out a notification to avoid confusing existing users into thinking their forms would break. Please open a ticket and let us know the hosts and emails of the affected forms so we can investigate further.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants