Skip to content

feat: Better Embedding of Link Surveys #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jobenjada merged 26 commits into from
Oct 4, 2023
Merged

feat: Better Embedding of Link Surveys #873

jobenjada merged 26 commits into from
Oct 4, 2023

Conversation

@gupta-piyush19
Copy link
Contributor

@gupta-piyush19 gupta-piyush19 commented Sep 30, 2023

What does this PR do?

Adds Better Embedding of Link Surveys

Fixes #687

embed-xp.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

  • Added a screen recording or screenshots to this PR
  • Filled out the "How to test" section in this PR
  • Read the contributing guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • Updated the Formbricks Docs if changes were necessary

@vercel
Copy link

vercel bot commented Sep 30, 2023

@gupta-piyush19 is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the enhancement New feature or request label Sep 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2023 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@gupta-piyush19 gupta-piyush19 changed the title Feat/embed xp feat: Better Embedding of Link Surveys Sep 30, 2023
@jobenjada jobenjada self-assigned this Oct 2, 2023
@jobenjada jobenjada assigned pandeymangg and unassigned jobenjada Oct 3, 2023
pandeymangg
pandeymangg requested changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@pandeymangg pandeymangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gupta-piyush19 Thanks a lot for this PR! looks and works great 🚀 🎉
I just have some comments (mostly nits), please check them 😊

pandeymangg
pandeymangg approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@pandeymangg pandeymangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@jobenjada jobenjada merged commit 06f03f6 into formbricks:main Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pandeymangg pandeymangg pandeymangg approved these changes

Assignees

@pandeymangg pandeymangg

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE][500 Points] Better Embedding of Link Surveys

3 participants

@gupta-piyush19 @pandeymangg @jobenjada