@vidhikapadia2799 is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

All committers have signed the CLA.

Thank you for following the naming conventions for pull request titles! 🙏

hey @vidhikapadia2799 thanks for your PR :) The screenshots look great!

Can you pls sign the Contributor CLA and fix the merge conflict?

@ShubhamPalriwala will then review your PR.

Cheers!

Hi @jobenjada, resolved merge conflicts. Also signed contributor CLA.

@ShubhamPalriwala Can you please review the PR.

Thanks.

Hey @ShubhamPalriwala , thanks for reviewing PR.

1. I have mistakenly changes label for Image and Upload. Made changes to label and not to id otherwise need to make many change in already built in Image component.
2. And called api on server side to prevent leaking secret key.
3. Also removed NEXT_PUBLIC as suggested made server side api call.

Done with other suggested changes.Can you please have a look and let me know if any other changes required.

Looking forward to contribute to formbricks.

Thanks.

Hey @vidhikapadia2799, thanks a lot for making the changes! 😄 Looks great! It works nicely too, just one change to keep in line with the product's policies:

Currently, in the link survey rendering action, you load the image from unsplash API directly. This might cause issues with the Policy for the end-user who is filling the form as they will be making a call to the Unsplash domain.

To tackle this, what we can do is that, once the survey creator selects an image from Unsplash, we upload it in the same way we do if a manual image was uploaded on our servers! In this way, when an end-user views the survey, they get the image from the formbricks servers itself rather than a third-party.

Let me know if you have any doubts around this or need some help!

Hi @ShubhamPalriwala , I have made the requested changes. Can you please have a look ?

Let me know if any changes are required.

Thanks

Hey @vidhikapadia2799, thanks a lot for your changes! They look good, I made some minor UX tweaks & passed the env var from a server component to the client components rather than getting them from a server action.

Hi @ShubhamPalriwala , I have gone through the changes you made and will make sure from next time to keep following way.

One thing I noticed, there is one console.log and some commented code in your changes. Do we need to keep that or remove it ?

good catch 😁 i still have some work to do on this PR, once done, I'll ping you as well, so you can understand the changes! thanks again

Hey @ShubhamPalriwala

I'm getting the following error after clicking on one of the preselected images:

leads to

2. We should pull 9 or 12 images, not 10:

3. Some of the images don't work. I click on them and it does replace the text but not the image (see mismatch of author here):

4. Image quality: I feel that we compress them a bit too much (or pull to small an image). Maybe it's my 4k screen but the images seem to be quite pixelated, especially detail shots don't really work.

Look at the resolution:

5. Production app requirements: Please make sure all of this is applied correctly (as much as you can do it):

6. I would love a "Load more" button which loads another 9 images. Since we're moving the scope anyways: Can you add that? 😉

Thanks! :)

Fixed & Made all the changes as suggested, please take a look 🤞🏼

/award 500

Awarding vidhikapadia2799: 500 points!

The latest updates on your projects. Learn more about Vercel for Git ↗︎