Skip to content

Conversation

@KapadiaNaitik
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel
Copy link

vercel bot commented Dec 3, 2023

@KapadiaNaitik is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2023

Thank you for following the naming conventions for pull request titles! 🙏

@mattinannt
Copy link
Member

@pandeymangg Thanks a lot for updating the PR 😊🚀
I got stuck in my testing. I have two consecutive cal-com questions. After finishing a booking in the first question; I get redirected to the second question, but I see the confirmation screen and the question doesn't seem to reset, which leads to a lot of confusion as to what happened ;-)

Screenshot 2023-12-11 at 16 34 31

@jobenjada
Copy link
Member

jobenjada commented Dec 11, 2023

hey @KapadiaNaitik

Thanks for the PR :) Here is my feedback:

  1. Description is not displayed:
image
  1. Change default button label to "Skip"

Its a bit confusing with the Cal UI inside of the question card. To make sure that the people actually complete the booking, we change the default button label to "Skip" so it becomes clearer what the button does.

image
  1. If question is required, remove the Skip button completely:
image
  1. The "Optional" hint is missing when the question is optional:
image image
  1. Rename question type to "Schedule a meeting"
image
  1. Change wording to "Add your Cal.com username or username/event"
image
  1. The window in a window look on link surveys isn't great, but for now its ok imo @mattinannt
image

@mattinannt
Copy link
Member

@jobenjada Anshuman updated the PR; can you please check again 😊

@jobenjada
Copy link
Member

Hey! Looks great 😍

Last thing: Pls change default from rick to rick/get-rick-rolled so that we show the user that they can save a step in the booking by adding /event to their user name.

After this, LGTM!

Good job @KapadiaNaitik and @pandeymangg

@mattinannt mattinannt enabled auto-merge December 19, 2023 07:42
@mattinannt mattinannt added this pull request to the merge queue Dec 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2023
@mattinannt mattinannt added this pull request to the merge queue Dec 19, 2023
Merged via the queue into formbricks:main with commit b275cce Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants