@KapadiaNaitik is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

Thank you for following the naming conventions for pull request titles! 🙏

Your code looks pretty solid overall, and you did a good job at integrating the File Upload feature. There are a few areas, though, where we could make some potential improvements:

1. Duplicate ID: In FileUploadQuestionForm.tsx you're using the same id 'm' for multiple Switch components. Please assign unique identifiers to each Switch.

2. Inline Comments: In FileUploadQuestion.tsx, lines 23-27, you have commented-out code. If this was intended to be removed, then I would suggest deleting it to improve readability and maintain clean codebase.

    ```tsx
         <form onSubmit={(e) => {
        e.preventDefault();
        //  if ( validateInput(value as string, question.inputType, question.required)) {
        onSubmit({ [question.id]: "submitted" });
        // }
    ```
   

3. Unused Param: In the SubmitButton component in FileUploadQuestion.tsx, the onClick prop for the SubmitButton seems to do nothing.

    ```tsx
        <SubmitButton
          ...
          onClick={() => {}}
        />
    ```
   

   Consider removing it if it's not needed or implement the onClick action if it was overlooked.

4. Handle File Upload: Currently, I see no functionality to handle file upload in your form. Do remember to implement an input field of type "File" and a function to handle these file uploads.

5. Data Validation: There does not appear to be any form of file upload size or type validation in the back-end. It's important to always validate form inputs both on the client-side and the server-side for security and data integrity reasons. I suggest adding checks for these in the back-end and client side as well.

That's pretty much about it. Great job on the PR!

@mattinannt these things I couldn't solve:

1. Better error message when someone tries to upload a too large image. It just says "Upload failed!" - in case we can detect that it happened bc the file size is above the free level, we should display the File Too Large error message.

If not, we should at least add "Try again with a smaller file."

2. When a file is deleted out of the uploader, the selection window is always opened again. I don't like the UX, bc when you delete something you dont necessarily want to upload a new file.

I've tried stopPropagation and moving the input a level up to not be a child but a sibling of the label (as GPT suggested). Can you fix this?

Rest works well :)

@mattinannt these things I couldn't solve:

1. Better error message when someone tries to upload a too large image. It just says "Upload failed!" - in case we can detect that it happened bc the file size is above the free level, we should display the File Too Large error message.

If not, we should at least add "Try again with a smaller file."

2. When a file is deleted out of the uploader, the selection window is always opened again. I don't like the UX, bc when you delete something you dont necessarily want to upload a new file.

I've tried stopPropagation and moving the input a level up to not be a child but a sibling of the label (as GPT suggested). Can you fix this?

Rest works well :)

Works great. Would like to see it in the next release <3

The upload functionality is not working for in-app surveys right now, this is due to an overlook in the FileUpload component, will fix this today so that this can get closed 💪