Skip to content

Conversation

@sundaram2021
Copy link
Contributor

@sundaram2021 sundaram2021 commented Oct 14, 2023

#pricing -> /pricing

What does this PR do?

On mobile screens , in the Hamburger menu the pricing does not navigates anywhere .I basically fixes that and now it works fine

Fixes # (1157)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • [ x] Filled out the "How to test" section in this PR
  • [ x] Read How we Code at Formbricks
  • [ x] Self-reviewed my own code
  • [ x] Commented on my code in hard-to-understand bits
  • [x ] Ran pnpm build
  • [ x] Checked for warnings, there are none
  • [ x] Removed all console.logs
  • [ x] Merged the latest changes from main onto my branch with git pull origin main
  • [ x] My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

#pricing   ->   /pricing
@vercel
Copy link

vercel bot commented Oct 14, 2023

@sundaram2021 is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2023

Thank you for following the naming conventions for pull request titles! 🙏

@sundaram2021 sundaram2021 changed the title Update Header.tsx Fix: Pricing Link in mobile menu on LP , Update Header.tsx Oct 14, 2023
@jobenjada jobenjada changed the title Fix: Pricing Link in mobile menu on LP , Update Header.tsx fix: Pricing Link in mobile menu on LP , Update Header.tsx Oct 15, 2023
@jobenjada jobenjada added this pull request to the merge queue Oct 15, 2023
@jobenjada jobenjada added hacktoberfest complete these issues to gather points for Hacktoberfest hacktoberfest-accepted formtribe-2023 labels Oct 15, 2023
Merged via the queue into formbricks:main with commit 9e68dfd Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest complete these issues to gather points for Hacktoberfest hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants