Skip to content

fix: Added DISCORD to the Footer.tsx #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jobenjada merged 2 commits into from
Oct 14, 2023
Merged

fix: Added DISCORD to the Footer.tsx #1154

jobenjada merged 2 commits into from
Oct 14, 2023

Conversation

@Sha1kh4
Copy link
Contributor

@Sha1kh4 Sha1kh4 commented Oct 14, 2023

Fix for issue #1147 where :
No Discord icon in main site. but their is in docs was mentioned

What does this PR do?

Adds discord to footer file which is used on home pafe
Fixes # (issue)

Type of change

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@Sha1kh4
Added DISCORD to the Footer.tsx
f685c46 
Fix for issue #1147 where :
No Discord icon in main site. but their is in docs
was mentioned
@vercel
Copy link

vercel bot commented Oct 14, 2023

@Sha1kh4 is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2023 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@Sha1kh4 Sha1kh4 changed the title Added DISCORD to the Footer.tsx fix: Added DISCORD to the Footer.tsx Oct 14, 2023
@jobenjada jobenjada enabled auto-merge October 14, 2023 15:54
@jobenjada
Copy link
Member

jobenjada commented Oct 14, 2023

Looks good, went into merge queue! Thanks :)

@jobenjada jobenjada added this pull request to the merge queue Oct 14, 2023
Merged via the queue into formbricks:main with commit a8e103f Oct 14, 2023
@shashankbhatgs
Copy link

shashankbhatgs commented Oct 18, 2023

@jobenjada is the discord link changed or broken? bcz not able to join via that link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sha1kh4 @jobenjada @shashankbhatgs