Skip to content

fix: minor ui fixes #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jobenjada merged 3 commits into from
Oct 15, 2023
Merged

fix: minor ui fixes #1138

jobenjada merged 3 commits into from
Oct 15, 2023

Conversation

@aryabyte21
Copy link
Contributor

@aryabyte21 aryabyte21 commented Oct 14, 2023

What does this PR do?

Minor ui fixes in the website like padding around Best practices tab in the navbar and centering the pricing plans

Fixes # (issue)
Screenshot 2023-10-14 at 12 29 15 PM
Screenshot 2023-10-14 at 12 49 42 PM

Screenshot 2023-10-14 at 12 49 59 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@aryabyte21
fix: minor ui fixes
8edcc3a 
Signed-off-by: aryabyte21 <arya2001bhosale@gmail.com>
@vercel
Copy link

vercel bot commented Oct 14, 2023

@aryabyte21 is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2023 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@jobenjada
Copy link
Member

jobenjada commented Oct 14, 2023

hey @aryabyte21 !

Thanks for this PR.

This is supposed to be aligned to the right:

image

These are the CTAs for the respective columns.

Please remove this, can merge the focus tweak tho ;)

@jobenjada jobenjada marked this pull request as draft October 14, 2023 16:44
@jobenjada jobenjada self-assigned this Oct 14, 2023
@aryabyte21
fixed position of pricing ctas
13c5b4f 
Signed-off-by: aryabyte21 <arya2001bhosale@gmail.com>
@jobenjada jobenjada added hacktoberfest complete these issues to gather points for Hacktoberfest hacktoberfest-accepted formtribe-2023 labels Oct 15, 2023
@jobenjada jobenjada marked this pull request as ready for review October 15, 2023 15:32
@jobenjada jobenjada enabled auto-merge October 15, 2023 15:32
@jobenjada
Copy link
Member

jobenjada commented Oct 15, 2023

thanks!!

@jobenjada jobenjada added this pull request to the merge queue Oct 15, 2023
Merged via the queue into formbricks:main with commit c64cc13 Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jobenjada jobenjada

Labels

hacktoberfest complete these issues to gather points for Hacktoberfest hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aryabyte21 @jobenjada