Skip to content

fix: twitter-icon-in-docs-footer-section #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jobenjada merged 2 commits into from
Oct 14, 2023
Merged

fix: twitter-icon-in-docs-footer-section #1134

jobenjada merged 2 commits into from
Oct 14, 2023

Conversation

@itzabhinavarya
Copy link
Contributor

@itzabhinavarya itzabhinavarya commented Oct 13, 2023

What does this PR do?

This PR solve the twitter icon in the docs footer section, which is not the lastest icon.

For reference:
This PR fix the issue no. #1113

image

Fixes # (issue)
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

@vercel
Copy link

vercel bot commented Oct 13, 2023

@itzabhinavarya is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@itzabhinavarya
Copy link
Contributor Author

itzabhinavarya commented Oct 13, 2023

@ShubhamPalriwala Sir Please check this PR, For reference issue no. #1113

@itzabhinavarya itzabhinavarya mentioned this pull request Oct 14, 2023
Closed
2 tasks
@itzabhinavarya
Copy link
Contributor Author

itzabhinavarya commented Oct 14, 2023 •
edited
Loading

@ShubhamPalriwala Sir Please reveiw this PR.

@jobenjada jobenjada enabled auto-merge October 14, 2023 15:46
@jobenjada
Copy link
Member

jobenjada commented Oct 14, 2023

Thanks, going in the merge queue now!

@jobenjada jobenjada added this pull request to the merge queue Oct 14, 2023
Merged via the queue into formbricks:main with commit 6f5e05e Oct 14, 2023
@itzabhinavarya
Copy link
Contributor Author

itzabhinavarya commented Oct 14, 2023

Thank you @jobenjada Sir for merging this PR.

@itzabhinavarya itzabhinavarya deleted the twitter-icon-in-docs-footer-section branch October 14, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@itzabhinavarya @jobenjada