Skip to content

fix: Overflow of body across leaderboard on mobile screen #1120 & Doc's navbar was not responsive #1129 #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jobenjada merged 10 commits into from
Oct 15, 2023
Merged

fix: Overflow of body across leaderboard on mobile screen #1120 & Doc's navbar was not responsive #1129 #1123

jobenjada merged 10 commits into from
Oct 15, 2023

Conversation

@bilalmirza74
Copy link
Contributor

@bilalmirza74 bilalmirza74 commented Oct 13, 2023 •
edited
Loading

What does this PR do?

Fixes #1120 & #1129

Before

c

After

b

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel
Copy link

vercel bot commented Oct 13, 2023

@bilalmirza74 is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@github-actions github-actions bot added the bug Something isn't working label Oct 13, 2023
@bilalmirza74
Copy link
Contributor Author

bilalmirza74 commented Oct 13, 2023

also fixed the hamburger menu position

@bilalmirza74 bilalmirza74 mentioned this pull request Oct 14, 2023
Closed
2 tasks
@jobenjada
Copy link
Member

jobenjada commented Oct 14, 2023

I think I cannot follow you: What exactly is broken? And how did you fix it?

Please paste before/after screenshots for everything this PR is supposed to fix ;)

Thanks!

@bilalmirza74
Copy link
Contributor Author

bilalmirza74 commented Oct 14, 2023

Before
c

After
f

@bilalmirza74
Copy link
Contributor Author

bilalmirza74 commented Oct 14, 2023

also Fixed
Doc's navbar was not responsive #1129

in this PR only

@bilalmirza74
Copy link
Contributor Author

bilalmirza74 commented Oct 14, 2023

before

be

After

a

@bilalmirza74 bilalmirza74 mentioned this pull request Oct 14, 2023
Closed
2 tasks
@bilalmirza74
Copy link
Contributor Author

bilalmirza74 commented Oct 14, 2023

please add Labels

@bilalmirza74 bilalmirza74 changed the title fix: Overflow of body across leaderboard on mobile screen #1120 fix: Overflow of body across leaderboard on mobile screen #1120 & Doc's navbar was not responsive #1129 Oct 14, 2023
@bilalmirza74
Copy link
Contributor Author

bilalmirza74 commented Oct 15, 2023

@jobenjada
Please merge this pr so that i can fix other issues

@jobenjada jobenjada added hacktoberfest complete these issues to gather points for Hacktoberfest formtribe-2023 labels Oct 15, 2023
@bilalmirza74
Copy link
Contributor Author

bilalmirza74 commented Oct 15, 2023 •
edited
Loading

Console errors are the part of other issue
Please merge this
Then I can fix console errors, ui sticking left side or reload,..

@jobenjada jobenjada enabled auto-merge October 15, 2023 17:21
@jobenjada
Copy link
Member

jobenjada commented Oct 15, 2023

Tweaked it quite a bit but went into merge queue now :)

@jobenjada jobenjada added this pull request to the merge queue Oct 15, 2023
@bilalmirza74
Copy link
Contributor Author

bilalmirza74 commented Oct 15, 2023

Thanks

Merged via the queue into formbricks:main with commit accd977 Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working hacktoberfest complete these issues to gather points for Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG][FormTribe 🔥][50 Points] Overflow of body across leaderboard on mobile screen

2 participants

@bilalmirza74 @jobenjada