Skip to content

chore: Add shelf.nu to oss fields api endpoint #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jobenjada merged 2 commits into from
Oct 14, 2023
Merged

chore: Add shelf.nu to oss fields api endpoint #1110

jobenjada merged 2 commits into from
Oct 14, 2023

Conversation

@DonKoko
Copy link
Contributor

@DonKoko DonKoko commented Oct 12, 2023

What does this PR do?

Adds shelf.nu to oss friends endpoint

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

Query the endpoint

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel
Copy link

vercel bot commented Oct 12, 2023

@DonKoko is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@DonKoko DonKoko changed the title Add shelf.nu to oss fields api endpoint chore: Add shelf.nu to oss fields api endpoint Oct 12, 2023
@jobenjada jobenjada self-assigned this Oct 13, 2023
@jobenjada jobenjada enabled auto-merge October 14, 2023 15:41
@jobenjada jobenjada added this pull request to the merge queue Oct 14, 2023
Merged via the queue into formbricks:main with commit 6a5260f Oct 14, 2023
@rajmayank21061
Copy link

rajmayank21061 commented Oct 26, 2023

There is a appreciative problem fixing which was better for issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jobenjada jobenjada

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DonKoko @rajmayank21061 @jobenjada