Skip to content

feat: Add welcome card #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattinannt merged 51 commits into from
Oct 17, 2023
Merged

feat: Add welcome card #1073

mattinannt merged 51 commits into from
Oct 17, 2023

Conversation

@KapadiaNaitik
Copy link
Contributor

@KapadiaNaitik KapadiaNaitik commented Oct 10, 2023

What does this PR do?

Fixes #1055

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

Will Update During Final Review
  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel
Copy link

vercel bot commented Oct 10, 2023

@KapadiaNaitik is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added enhancement New feature or request formtribe-2023 hacktoberfest complete these issues to gather points for Hacktoberfest labels Oct 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@KapadiaNaitik KapadiaNaitik marked this pull request as draft October 10, 2023 11:56
@jobenjada
Copy link
Member

jobenjada commented Oct 13, 2023

Hey @KapadiaNaitik how is it? Is this ready for review as discussed on Discord? :) Would love to release the other upload related issues today which would reuse some of your code, so this should get merged today :pray

1 similar comment
@jobenjada
Copy link
Member

jobenjada commented Oct 13, 2023

Hey @KapadiaNaitik how is it? Is this ready for review as discussed on Discord? :) Would love to release the other upload related issues today which would reuse some of your code, so this should get merged today :pray

@KapadiaNaitik
Copy link
Contributor Author

KapadiaNaitik commented Oct 13, 2023

Hey, @jobenjada it's done except for the Lucide Icon for enter and I was facing some issues with types/react and Lucide icon. I have already talked to and informed @pandeymangg and he had a look(it was a weird dependency issue afaik). I will follow up once again with him and get this done as soon as possible. Sorry for the delay

@KapadiaNaitik KapadiaNaitik marked this pull request as ready for review October 13, 2023 09:44
pandeymangg
pandeymangg requested changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@pandeymangg pandeymangg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @KapadiaNaitik for this PR! looks and works great! 🥳
I have left some comments, please go through them. For using the Image component from next/image, you'll need to modify the images.remotePatterns field in the next.config.mjs file under apps/web. Please add the following at the end of that array:

{
  protocol: "http",
  hostname: "localhost",
},
{
  protocol: "https",
  hostname: "app.formbricks.com",
},

packages/surveys/src/components/WelcomeQuestion.tsx Outdated
return (
<div>
{question.companyLogo && (
<img
Copy link
Contributor

@pandeymangg pandeymangg Oct 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the Image component from next/image here 🙏

Copy link
Contributor Author

@KapadiaNaitik KapadiaNaitik Oct 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next/Image not working for some reason

@KapadiaNaitik
Copy link
Contributor Author

KapadiaNaitik commented Oct 17, 2023

@jobenjada I have pushed the required tweaks

@pandeymangg
Copy link
Contributor

pandeymangg commented Oct 17, 2023

LGTM! 🥳

@mattinannt mattinannt enabled auto-merge October 17, 2023 08:25
@mattinannt mattinannt added this pull request to the merge queue Oct 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2023
@mattinannt mattinannt changed the title feat: New Question Type Welcome feat: Add welcome card Oct 17, 2023
@mattinannt mattinannt enabled auto-merge October 17, 2023 08:56
@mattinannt mattinannt disabled auto-merge October 17, 2023 08:59
@mattinannt mattinannt enabled auto-merge October 17, 2023 08:59
@mattinannt mattinannt added this pull request to the merge queue Oct 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2023
@KapadiaNaitik
Copy link
Contributor Author

KapadiaNaitik commented Oct 17, 2023 •
edited
Loading

Hey @mattinannt looks like I and you both pushed our commits so welcomeCard got duplicated in clientSettings😅

@mattinannt mattinannt enabled auto-merge October 17, 2023 09:21
@mattinannt mattinannt added this pull request to the merge queue Oct 17, 2023
Merged via the queue into formbricks:main with commit 2c1abf8 Oct 17, 2023
@sentry
Copy link

sentry bot commented Oct 17, 2023 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Upload failed with status: 401 uploadFile(chunks/app/(app)/environments/[envir... View Issue
  • ‼️ Error: Upload failed with status: 400 uploadFile(chunks/app/(app)/environments/[envir... View Issue

Did you find this useful? React with a 👍 or 👎

@KapadiaNaitik KapadiaNaitik deleted the welcome branch October 20, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pandeymangg pandeymangg pandeymangg approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request hacktoberfest complete these issues to gather points for Hacktoberfest ❗️ migrations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE][FormTribe 🔥][750 Points] Question Type: Welcome Screen

4 participants

@KapadiaNaitik @jobenjada @pandeymangg @mattinannt