fix(@formatjs/unplugin): preserve space when removing JSX attribute on single line#6165
Merged
fix(@formatjs/unplugin): preserve space when removing JSX attribute on single line#6165
Conversation
…n single line
When a JSX attribute (e.g. description) preceded another attribute on the
same line and was removed, the removeJSXAttribute function was consuming
both the leading and trailing whitespace around the attribute. This left
no space separator between the element name and the next attribute,
producing invalid-looking output like:
<FormattedMessagedefaultMessage={...} />
The fix: stop consuming trailing whitespace. Expand backward only,
including the preceding newline (for multi-line JSX) so entire lines are
cleanly removed in that case. This ensures the space before the following
attribute is always preserved on single-line elements.
Fixes #6164
Co-authored-by: Long Ho <longlho@users.noreply.github.com>
…SX attr - Fix bug where generated id was swallowed when description was the first JSX attribute (insertionPoint coincided with the removal range) - Change JSX insertionPoint to always use elementNode.name.end instead of firstAttr.start, making id insertion immune to attribute removals - Replace loose toContain/not.toContain test assertions with exact toBe checks for deterministic output verification Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a JSX attribute (e.g. description) preceded another attribute on the same line and was removed, the removeJSXAttribute function consumed both the leading and trailing whitespace, producing invalid-looking output like
<FormattedMessagedefaultMessage={...} />.Fixes #6164
Generated with Claude Code