Skip to content

chore: remove exported tests #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gfyrag merged 2 commits into from
Apr 8, 2025
Merged

chore: remove exported tests #1760

gfyrag merged 2 commits into from
Apr 8, 2025

Conversation

@gfyrag
Copy link
Contributor

@gfyrag gfyrag commented Apr 2, 2025

@gfyrag gfyrag requested a review from a team as a code owner April 2, 2025 14:37
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 2, 2025 •
edited
Loading

Walkthrough

This pull request modifies the event processing in libs/events/index.js by moving the parsing of the base variable into the event loop, ensuring a fresh parse for each event payload. In addition, it adds a log statement to output the aggregated object before writing it to a file. Several integration test files related to authentication (client credentials and JWT bearer) and wallet operations (creation, credit, and debit) have been removed.

Changes

File(s) Change Summary
libs/events/index.js Moved the parsing of the base variable inside the event loop for per-event re-parsing; added logging for the aggregated data.
tests/integration/suite/{auth-*, wallets-*} Deleted integration tests for authentication (client credentials, JWT bearer) and wallet operations (creation, credit, debit).

Sequence Diagram(s)

sequenceDiagram
    participant AF as Async Function
    participant EL as Event Loop
    participant Log as Console Logger
    participant WF as File Writer

    AF->>EL: Iterate through each event
    loop For each event
        EL->>EL: Re-parse `base` from event payload
    end
    EL->>AF: Update aggregated object
    AF->>Log: Log aggregated object
    AF->>WF: Write aggregated data to file
Loading

Possibly related PRs

Suggested labels

ee/auth, components/payments, components/ledger

Suggested reviewers

  • paul-nicolas
  • laouji

Poem

Hop through lines of code I go,
Parsing fresh with every flow.
Logging data with a joyful cheer,
Aggregated bytes now crystal clear.
I thump my paws for tests set free,
A rabbit’s code — as swift as can be! 🐇
Happy coding under the moonlit tree!

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Apr 2, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
libs/events/index.js (1)

26-26: Consider if this debug output is appropriate for production

The added console log will output the entire aggregated object, which could be problematic in production:

  1. May generate excessive log output for large services
  2. Could impact performance when processing many events
  3. Potentially exposes sensitive data in logs
- console.log(aggregated);
+ // For debugging purposes only
+ // console.log(aggregated);

Alternatively, consider limiting this to development environments or adding more context:

- console.log(aggregated);
+ console.log('Writing aggregated events to file...', 
+   Object.keys(aggregated).map(s => `${s}: ${Object.keys(aggregated[s]).length} versions`));
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1860861 and 800f5ee.

⛔ Files ignored due to path filters (23)
  • libs/events/generated/all.json is excluded by !**/generated/**, !**/*.json, !**/generated/**
  • libs/events/generated/payments/v2.0.0/CONNECTOR_RESET.json is excluded by !**/generated/**, !**/*.json, !**/generated/**
  • libs/events/generated/payments/v3.0.0/CONNECTOR_RESET.json is excluded by !**/generated/**, !**/*.json, !**/generated/**
  • libs/events/generated/payments/v3.0.0/DELETED_POOL.json is excluded by !**/generated/**, !**/*.json, !**/generated/**
  • libs/events/generated/payments/v3.0.0/SAVED_ACCOUNT.json is excluded by !**/generated/**, !**/*.json, !**/generated/**
  • libs/events/generated/payments/v3.0.0/SAVED_BALANCE.json is excluded by !**/generated/**, !**/*.json, !**/generated/**
  • libs/events/generated/payments/v3.0.0/SAVED_BANK_ACCOUNT.json is excluded by !**/generated/**, !**/*.json, !**/generated/**
  • libs/events/generated/payments/v3.0.0/SAVED_PAYMENT.json is excluded by !**/generated/**, !**/*.json, !**/generated/**
  • libs/events/generated/payments/v3.0.0/SAVED_PAYMENT_INITIATION.json is excluded by !**/generated/**, !**/*.json, !**/generated/**
  • libs/events/generated/payments/v3.0.0/SAVED_PAYMENT_INITIATION_ADJUSTMENT.json is excluded by !**/generated/**, !**/*.json, !**/generated/**
  • libs/events/generated/payments/v3.0.0/SAVED_PAYMENT_INITIATION_RELATED_PAYMENT.json is excluded by !**/generated/**, !**/*.json, !**/generated/**
  • libs/events/generated/payments/v3.0.0/SAVED_POOL.json is excluded by !**/generated/**, !**/*.json, !**/generated/**
  • libs/events/services/payments/v2.0.0/CONNECTOR_RESET.yaml is excluded by !**/*.yaml
  • libs/events/services/payments/v3.0.0/CONNECTOR_RESET.yaml is excluded by !**/*.yaml
  • libs/events/services/payments/v3.0.0/DELETED_POOL.yaml is excluded by !**/*.yaml
  • libs/events/services/payments/v3.0.0/SAVED_ACCOUNT.yaml is excluded by !**/*.yaml
  • libs/events/services/payments/v3.0.0/SAVED_BALANCE.yaml is excluded by !**/*.yaml
  • libs/events/services/payments/v3.0.0/SAVED_BANK_ACCOUNT.yaml is excluded by !**/*.yaml
  • libs/events/services/payments/v3.0.0/SAVED_PAYMENT.yaml is excluded by !**/*.yaml
  • libs/events/services/payments/v3.0.0/SAVED_PAYMENT_INITIATION.yaml is excluded by !**/*.yaml
  • libs/events/services/payments/v3.0.0/SAVED_PAYMENT_INITIATION_ADJUSTMENT.yaml is excluded by !**/*.yaml
  • libs/events/services/payments/v3.0.0/SAVED_PAYMENT_INITIATION_RELATED_PAYMENT.yaml is excluded by !**/*.yaml
  • libs/events/services/payments/v3.0.0/SAVED_POOL.yaml is excluded by !**/*.yaml
📒 Files selected for processing (6)
  • libs/events/index.js (2 hunks)
  • tests/integration/suite/auth-client-credentials.go (0 hunks)
  • tests/integration/suite/auth-jwt-bearer.go (0 hunks)
  • tests/integration/suite/wallets-create.go (0 hunks)
  • tests/integration/suite/wallets-credit.go (0 hunks)
  • tests/integration/suite/wallets-debit.go (0 hunks)
💤 Files with no reviewable changes (5)
  • tests/integration/suite/auth-client-credentials.go
  • tests/integration/suite/wallets-create.go
  • tests/integration/suite/wallets-credit.go
  • tests/integration/suite/auth-jwt-bearer.go
  • tests/integration/suite/wallets-debit.go
🔇 Additional comments (1)
libs/events/index.js (1)

15-15: Improved isolation by parsing base for each event

Moving yaml.parse(rawBase) into the innermost loop ensures each event gets a fresh copy of the base object. This prevents potential side effects where modifications from one event could affect subsequent events.

@gfyrag gfyrag enabled auto-merge (rebase) April 2, 2025 14:42
@gfyrag gfyrag merged commit 1fc0dbf into release/v3.0 Apr 8, 2025
4 checks passed
@gfyrag gfyrag deleted the chore/remove-exported-tests branch April 8, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@Dav-14 Dav-14 Dav-14 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gfyrag @Dav-14 @paul-nicolas