Skip to content

Classify non-tracking local branches and non-upstream remote-tracking branches too#147

Merged
mergify[bot] merged 6 commits intomasterfrom
non-upstreams
Aug 14, 2020
Merged

Classify non-tracking local branches and non-upstream remote-tracking branches too#147
mergify[bot] merged 6 commits intomasterfrom
non-upstreams

Conversation

@foriequal0
Copy link
Copy Markdown
Owner

@foriequal0 foriequal0 commented Aug 10, 2020 •
edited
Loading

breaking change
This PR repurposes --delete local, and --delete remote flags. I think that they are rarely used, and it is good to reduce combinatorial complexities of the --delete flag.

resolves: #137

@foriequal0 foriequal0 added enhancement New feature or request breaking changes labels Aug 10, 2020
@foriequal0 foriequal0 marked this pull request as draft August 10, 2020 10:03
@foriequal0
Use rayon scope spawn directly
82112be
@foriequal0
Classify non-tracking local branches and non-upstream remote-tracking…
b47fbb0 
… branches too
@foriequal0
--scan option
47cf0dc
@foriequal0
Pre filter branches to classify based on --scan options
5ee6b4e 
Classifying all remote tracking branches from all remotes will make `git-trim` slower,
the output messy, and also users to mistakenly delete unwanted remotes.
It'll be prevented by putting them behind the prefiltering option `--scan`.
@foriequal0 foriequal0 marked this pull request as ready for review August 14, 2020 07:05
@foriequal0 foriequal0 added the mergify Queue mergify label Aug 14, 2020
@mergify mergify bot merged commit 7b8ea96 into master Aug 14, 2020
@mergify mergify bot deleted the non-upstreams branch August 14, 2020 07:29
@mergify mergify bot removed the mergify Queue mergify label Aug 14, 2020
@foriequal0
Copy link
Copy Markdown
Owner Author

foriequal0 commented Aug 14, 2020 •
edited
Loading

I've put this feature behind new --scan flag, and --delete remote flag.
Classifying all remote tracking branches from all remotes will make git-trim slower,
the output messier (I think you don't want see a bunch of collaborator-a/master [merged, but: fitered]s),
and also users to mistakenly delete unwanted remotes.
Also, full-scanning and deleting non-upstream remotes are relatively rare cases.

@foriequal0 foriequal0 mentioned this pull request Aug 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking changes enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Request: Delete remote merged branches

1 participant

@foriequal0