Enhance Chart.js Tooltip for both Light and Dark Mode#23141
Open
FrancisTRAlt wants to merge 2 commits intoforem:mainfrom
Open
Enhance Chart.js Tooltip for both Light and Dark Mode#23141FrancisTRAlt wants to merge 2 commits intoforem:mainfrom
FrancisTRAlt wants to merge 2 commits intoforem:mainfrom
Conversation
Contributor
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
|
Do you think it makes sense to make the tooltip background light and just keep the text dark in light mode? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR fixes the Issue where the text is invisible if you were in dark mode. Created the Tooltip that Chart.js uses to make it visible for both Light and Dark Mode.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Make sure you are signed in. Same steps to reproduce as mention in the issue:
UI accessibility checklist
Added/updated tests?
have not been included
What gif best describes this PR or how it makes you feel?