block/report abuse in dev-connect#2074
Merged
benhalpern merged 16 commits intoforem:masterfrom Mar 26, 2019
Merged
Conversation
d601184 to
7770ebf
Compare
benhalpern
requested changes
Mar 21, 2019
Contributor
benhalpern
left a comment
There was a problem hiding this comment.
This is good to go, pending the one requested change.
benhalpern
reviewed
Mar 26, 2019
| def block_chat | ||
| chat_channel = ChatChannel.find(params[:chat_id]) | ||
| policy = ChatChannelPolicy.new(current_user, chat_channel) | ||
| if policy.open? && chat_channel.valid? && chat_channel.channel_type == "direct" |
Contributor
There was a problem hiding this comment.
This isn't really how policies are meant to be used, but this is technically solving the problem. Since this is outside of where you typically contribute, I'll just merge this and refactor it myself later and let you know what I did. I think that's simpler than holding this up right now.
benhalpern
approved these changes
Mar 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Adds blocking and report abuse to DEV Connect to prevent abuse. Users can keep their inbox open and blocked users cannot re-open chat with them.
blockedis now an option forChatChannelstatus. This prevents aChatChannelfrom being rendered in/connectand doesn't allowstatusto be changed toactive. Currently, there is no way to unblock someone on/connecton the user side.Related Tickets & Documents
continues off from #1563
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Blocking
Reporting Abuse
Added to documentation?