Merged
Conversation
Collaborator
|
please run "make format" and "make generate" |
yp969803
reviewed
Jul 12, 2025
client/src/pages/Login/index.tsx
Outdated
| <div className="inputDiv" tabIndex={0}> | ||
| <input | ||
| type="password" | ||
| type={showPassword ? 'text' : 'password'} |
Collaborator
There was a problem hiding this comment.
Suggested change
| type={showPassword ? 'text' : 'password'} | |
| type={showPassword ? '' : 'password'} |
Contributor
Author
There was a problem hiding this comment.
@yp969803 bro, i staged 3 files.. or i add all changed files to commit ..
Collaborator
|
stage everything |
Collaborator
|
useless files are ignored by gitignore |
Contributor
Author
i staged all thing .. now it's giving build errors .. |
Collaborator
|
ping @yashisrani |
2ebd71a to
54cee0d
Compare
Collaborator
|
run these commands |
Collaborator
|
ping @yashisrani |
Collaborator
|
run make generate && make format |
d926559 to
635bf21
Compare
529df32 to
971942a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #92
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Type of change
What type of changes does your code introduce to the wharf? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the testing guidelines for recommendations about automated tests.