Skip to content

Conversation

@gnguyen-sfdc
Copy link
Contributor

Adding v48 (Spring '20) support to workbench,

@gnguyen-sfdc
Copy link
Contributor Author

@ntotten Can you (or anyone else?) review this PR adding support for v48 to workbench? Thank you.

"label" => "Default API Version",
"description" => "Default API version to be used for login. This setting does not affect the API version of the current session. Recommended to choose latest version. Some features may act unexpectedly when using older versions.",
"default" => "46.0",
"default" => "48.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default version should be one behind the current version. So this should be "47.0"

@praksb
Copy link
Contributor

praksb commented Jan 7, 2020

@gnguyen-sfdc I just had one comment. I can approve this review after the small change is made.

@gnguyen-sfdc
Copy link
Contributor Author

@praksb Thank you for reviewing. I made the change to the default API version.

@praksb praksb merged commit 4e91fc2 into forceworkbench:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants