[filewatcher] Ignore file changes with same content#2511
Merged
justvanrossum merged 6 commits intomainfrom Mar 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows + OneDrive storage gives an interesting behavior: after we write a file, OneDrive will touch the file after about a second. The content doesn't change, but the modification time does, so we'll get a "file changed" event. But since the modified time is now different from when we wrote the file, the change gets interpreted as an external change, and will cause data to be reloaded. This is especially clear to observe when editing the OpenType features for a UFO: the cursor will jump back to the beginning of the document soon after any edit.
Solution: we will do extra work and record a hash for the contents of any file written, and will use that to compare with the hash of the file when receiving a file changed event. If it's the same, we ignore the event.
TODO: