Skip to content

Add "glyph sets" functionality to editor#2489

Merged
justvanrossum merged 51 commits intomainfrom
editor-glyphsets
Mar 12, 2026
Merged

Add "glyph sets" functionality to editor#2489
justvanrossum merged 51 commits intomainfrom
editor-glyphsets

Conversation

@justvanrossum
Copy link
Copy Markdown
Member

@justvanrossum justvanrossum commented Mar 12, 2026

This brings the editor in line with the font overview, and finally allows us to use custom glyph names + code points in the editor.

  • Refactor editor view info <-> URL mechansm
  • Add glyph sets UI from font overview to the editor's glyph search panel
  • Make glyph set selection stick when opening editor from font overview and vice versa
  • Make undefined glyphs get their names and/or code points from the combined selected glyph sets
  • Move the business logic from glyphsets-ui.js to the new glyphsets-controller.js module

@justvanrossum
Move controller construction to module
4049ba4
@justvanrossum
Move myGlyphSets controller to module
863802b
@justvanrossum
Let accordion item be open by default
41134a0
@justvanrossum
Initialize glyph set settings items
51e9d6f
@justvanrossum
Set up glyph sets accordion
a3dd603
@justvanrossum
Keep glyph sets accordion at the bottom
aa6c94c
@justvanrossum
Split GlyphSetsController into its own module
d3b7ef4
@justvanrossum
Adjust imports
47f2c3a
@justvanrossum
Set up glyphsets controller
c786e0d
@justvanrossum
Move glyphsets initialization to scene controller
c4f8f5a
@justvanrossum
Fix default key
6db8ee4
@justvanrossum
Remove duplicate line (it's done inside this.setupSceneSettings() as …
effe608 
…well)
@justvanrossum
Move dynamic things out of defaults
f560c96
@justvanrossum
Refactor scene settings serialization: move to scene controller, make…
9478d1a 
… data-driven
@justvanrossum
Populate missing items
9a24101
@justvanrossum
add glyph set selection to settings
208ebcd
@justvanrossum
Rename method
e15733a
@justvanrossum
Expand comment
4674414
@justvanrossum
Return combinedGlyphMap, the caller can turn it into a list if needed
823eb1e
@justvanrossum
Protect agains undefined oldValue
1be3e80
@justvanrossum
Make search list use combined glyph map
b938783
@justvanrossum
Add optional fontGlyphMap to search list, so it can differentiate bet…
9c53615 
…ween existing and non-existing glyphs
@justvanrossum
Add combinedGlyphMap and combinedCharacterMap to settings, compute dy…
139b9c8 
…namically from glyphset selection and glyph map
@justvanrossum
Reject null-ish rect
bca6771
@justvanrossum
Ignore null-ish rect when setting the view box
b137356
@justvanrossum
Test that an unknown character results in an undefined glyph name
9b7f1e5
@justvanrossum
Add fallback glyphmap and charmap args to characterLinesFromString
7be96af
@justvanrossum
Use fallback char map and glyph map
3be2f03
@justvanrossum
Test that the fallback charmap does something
dd0e8c0
@justvanrossum
Test non-standard glyph name
d28bf5f
@justvanrossum
More test cases
21cca9f
@justvanrossum
Use fallback charmap in expand glyph name
dff7bf4
@justvanrossum
Rename outlier glyph and char
5fd8542
@justvanrossum
Verify that shortcut glyph names work with fallback, too
a4c1b24
@justvanrossum
Add to comment
d23128e
@justvanrossum
Fix arguments
115a6ba
@justvanrossum
Use fallback glyphset when expanding glyph name
4da02b0
@justvanrossum
Respond to changes in combinedCharacterMap; move glyphInfoFromGlyphNa…
edad23c 
…me here
@justvanrossum
This method moved to scene controller
adddadb
@justvanrossum
Use fallback char map
5c0b7f5
@justvanrossum
The method moved
809f3ae
@justvanrossum
The method moved
a54ad2c
@justvanrossum
Pass glyph set selection to editor
7ae33ba
@justvanrossum
Delete unused code
ee6de30
@justvanrossum
Pass view parameters to font overview, if any
b934b24
@justvanrossum
Don't set settings value at all if the viewInfo doesn't have it
0bea4db
@justvanrossum
Don't wait if we have no value
f88a094
@justvanrossum
Fix autoviewbox
5734ec2
@justvanrossum
Allow undefined glyphs from glyph sets to show up in glyph search dia…
ddc9cc6 
…log (opt-out)
@justvanrossum
Add ... for items that trigger a dialog
3fbfabc
@justvanrossum
Add ... for items that trigger a dialog
664597c
@justvanrossum justvanrossum merged commit 4ed05cc into main Mar 12, 2026
4 checks passed
@justvanrossum justvanrossum deleted the editor-glyphsets branch March 12, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@justvanrossum